Re: [PATCH 03/11] pinctrl: sophgo: Cleanup header includes
Inochi Amaoto <[email protected]>
| Newsgroups | dev.linux.lists.sophgo,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-tegra,org.ozlabs.lists.linux-aspeed,org.ozlabs.lists.openbmc |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jan 14, 2026 at 04:30:04PM +0100, Krzysztof Kozlowski wrote: > Remove unused includes from internal headers, because they do not have > following: bit manipulations, mutexes, spinlocks and struct devices. > These headers are included by actual C files, which seem to have all > necessary includes. > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > --- > drivers/pinctrl/sophgo/pinctrl-cv18xx.h | 4 ---- > drivers/pinctrl/sophgo/pinctrl-sg2042.h | 6 ------ > 2 files changed, 10 deletions(-) > > diff --git a/drivers/pinctrl/sophgo/pinctrl-cv18xx.h b/drivers/pinctrl/sophgo/pinctrl-cv18xx.h > index 759c0e604acf..973ab9a38fcf 100644 > --- a/drivers/pinctrl/sophgo/pinctrl-cv18xx.h > +++ b/drivers/pinctrl/sophgo/pinctrl-cv18xx.h > @@ -6,11 +6,7 @@ > #ifndef _PINCTRL_SOPHGO_CV18XX_H > #define _PINCTRL_SOPHGO_CV18XX_H > > -#include <linux/bits.h> > #include <linux/bitfield.h> > -#include <linux/mutex.h> > -#include <linux/spinlock.h> > -#include <linux/platform_device.h> > #include <linux/pinctrl/pinctrl.h> > #include <linux/pinctrl/pinconf.h> > > diff --git a/drivers/pinctrl/sophgo/pinctrl-sg2042.h b/drivers/pinctrl/sophgo/pinctrl-sg2042.h > index d481973fcf97..1a2b00dde1fa 100644 > --- a/drivers/pinctrl/sophgo/pinctrl-sg2042.h > +++ b/drivers/pinctrl/sophgo/pinctrl-sg2042.h > @@ -6,12 +6,6 @@ > #ifndef _PINCTRL_SOPHGO_SG2042_H > #define _PINCTRL_SOPHGO_SG2042_H > > -#include <linux/bits.h> > -#include <linux/bitfield.h> > -#include <linux/device.h> > -#include <linux/mutex.h> > -#include <linux/spinlock.h> > -#include <linux/platform_device.h> > #include <linux/pinctrl/pinctrl.h> > #include <linux/pinctrl/pinconf.h> > > > -- > 2.51.0 > Thanks. Reviewed-by: Inochi Amaoto <[email protected]> Regards, Inochi