Re: [PATCH 1/2] riscv: dts: sophgo: Move PLIC and CLINT node into CPU dtsi
Chen Wang <[email protected]>
| Newsgroups | dev.linux.lists.sophgo,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <MA5PR01MB12500483EBB07C8495004C053FE8AA@MA5PR01MB12500.INDPRD01.PROD.OUTLOOK.COM> |
On 1/17/2026 8:37 AM, Inochi Amaoto wrote: > On Thu, Jan 15, 2026 at 08:49:54AM +0800, Chen Wang wrote: >> On 1/13/2026 10:38 AM, Inochi Amaoto wrote: >>> As we have a separate CPU dtsi file, move the PLIC and CLINT >>> node to the CPU dtsi file. This will make the sg2042.dtsi force >>> peripheral devices, and make the CPU dtsi force CPU related >>> devices. >> LGTM, except for the word "force" in the commit message; it seems a bit odd. >> Perhaps it would be better to write: "This will make all peripheral devices >> are defined in the sg2042.dtsi >> >> and all CPU-related are defined in the CPU dtsi." >> >> Reviewed-by: Chen Wang <[email protected]> >> > Thanks, it should be "focus on", I wrote a wrong word, If it is > OK, I will fix this mistake when merging. > > Regards, > Inochi I think it's okay. Thanks, Chen >>> Signed-off-by: Inochi Amaoto <[email protected]> >>> --- >>> arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi | 305 ++++++++++++++++++++ >>> arch/riscv/boot/dts/sophgo/sg2042.dtsi | 303 ------------------- >>> 2 files changed, 305 insertions(+), 303 deletions(-) >>> >>> diff --git a/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi b/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi >>> index 94a4b71acad3..509488eee432 100644 >>> --- a/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi >>> +++ b/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi >> [......] >> >>