Re: [PATCH v2 1/7] dt-bindings: sound: sophgo: add CV1800B I2S/TDM controller binding
"Anton D. Stavinskii" <[email protected]>
| Newsgroups | dev.linux.lists.sophgo,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Jan 18, 2026 at 06:32:24PM +0400, Krzysztof Kozlowski wrote: > On 18/01/2026 18:07, Anton D. Stavinskii wrote: > > On Sun, Jan 18, 2026 at 11:14:34AM +0400, Krzysztof Kozlowski wrote: > >> > >> Please use subject prefixes matching the subsystem. You can get them for > >> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory > >> your patch is touching. For bindings, the preferred subjects are > >> explained here: > >> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > > > dt-bindings: sound: sophgo,cv1800b: add I2S/TDM controller > > No. Read again, I even gave you DIRECT doc link! > > > > > Is this anyhow better? Also in the documentation directory should go > > first but I didn't find such examples in git follow. > > Huh? How so? Where are you looking? 99% of commits have correct prefix. > Where do you see sound: > > b7d53fe53cb5 ASoC: dt-bindings: rtq9128: Add rtq9154 backward compatible > 35bffbe49dfd ASoC: dt-bindings: Convert realtek,rt5651 to DT schema > 70d95c5d2081 ASoC: dt-bindings: rockchip-spdif: Allow "port" node > f66e7da2a6b1 ASoC: dt-bindings: realtek,rt5640: Allow 7 for > 101b982654ac ASoC: dt-bindings: realtek,rt5640: Add missing properties/ > b540b4e157c4 ASoC: dt-bindings: realtek,rt5640: Document port node > 25b858474497 ASoC: dt-bindings: realtek,rt5640: Update jack-detect > 66b47b9c069f ASoC: dt-bindings: realtek,rt5640: Document mclk Sorry I'm new to this and learning. For some reason I thought that "binding dir" in "<binding dir>: dt-bindings: ..." is actual directory of introduced file. That is why I said couldn't find any example because I didn't find anything with "sound:". Thank you for clarification. Got it now(I hope so). Removing sound, adding ASoC. Also the word binding removed as you told me ASoC: dt-bindings: sophgo,cv1800b: add I2S/TDM controller