Re: [PATCH v4 5/6] ASoC: sophgo: add CV1800B internal DAC codec driver
Mark Brown <[email protected]>
| Newsgroups | dev.linux.lists.sophgo,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jan 20, 2026 at 11:06:07PM +0400, Anton D. Stavinskii wrote:
> help
> This driver provides an ASoC codec DAI for capture and basic
> control of the RXADC registers.
> -
> Say Y or M to build support for the Sophgo CV1800B
> internal analog ADC codec block (RXADC).
> The module will be called cv1800b-sound-adc
Extra change here.
> +static int cv1800b_dac_hw_params(struct snd_pcm_substream *substream,
> + struct snd_pcm_hw_params *params,
> + struct snd_soc_dai *dai)
> +{
> + struct cv1800b_priv *priv = snd_soc_dai_get_drvdata(dai);
> + int ret;
> + unsigned int rate = params_rate(params);
> + cv1800b_dac_mute(priv, false);
> + /* minimal decimation for 48kHz is 64*/
Nothing ever mutes the DAC so this is a bit redundant. The mute should
probably be a mute_stream() operation.
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAml4tG8ACgkQJNaLcl1U h9BHkQf+Kuc6BJjZWeAWQyoncG7fDBwM+k/TqBukcTrPjZHiGZ22yCkrEVWU06Lc qWWOu9GIJM4QfBsRLYI9IEvy0L4b3RZK72dHfIsK0YEOUydC1oKWRYsm4qUqHnou vXTYz6nDIuMxvIAlODl9SiLHxT4/BNRKMWdPl/RCV86jUbF7mBqyRpDx41tTTuen lzSUWIvK8ZhTmCfkB6mdBapl4oxYANInUjMxq/28hOUOJ3xXIiPLTn/UHFLVYmdX ORMrhBMCWuVIiagUgK8RwF0Uc9Fd1zPgfA5QjanVdstgKYDe1IhODVJNT5n+E2bE 8un1mgrWVdoXPo3r8LiZ9rth+YqXqw== =0mgc -----END PGP SIGNATURE-----