Re: [PATCH net-next v7 1/7] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems

On Sat, Mar 7, 2026 at 11:25 AM Krzysztof Kozlowski <[email protected]> wrote:
>
> On Fri, Mar 06, 2026 at 04:46:39PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <[email protected]>
> >
> > Describe the firmware-managed variant of the QCom DesignWare MAC. As the
> > properties here differ a lot from the HLOS-managed variant, lets put it
> > in a separate file. Since we need to update the maximum number of power
> > domains, let's update existing bindings referencing the top-level
> > snps,dwmac.yaml and limit their maxItems for power-domains to 1.
> >
> > Signed-off-by: Bartosz Golaszewski <[email protected]>
> > Reviewed-by: Romain Gantois <[email protected]> # For RZ/N1
>
> Can we drop half-baked reviews? Reviewing only that piece is not even
> possible, because it makes no sense outside of main change context. IOW,
> it's pointless review of nothing, if you do not actually review the main
> change impacting RZ/N1.
>

This is the first time I'm hearing we can't review individual parts of
changesets? I see your point about this particular patch and the fact
it only makes sense as a whole but is this the official policy for
parts of larger DTS patches?

Bart

> Also submitting patches do not really allow to apply reviewer's
> statement of oversight to inly part of the patch.
>
> It's called Ack then. Use proper tags if one does not actually review
> the patch.
>

I need to resend anyway so I'll drop it. I may also drop the two
hundred addresses from Cc b4 added. :)

Bart