Re: zsbl PR #135: sg2042 bootargs clobber fix
Chen Wang <[email protected]> Wed, 8 Jul 2026 07:53:24 +0800
| Newsgroups | dev.linux.lists.sophgo |
|---|---|
| Message-ID | <MA5P287MB6080E388CC6CFC501E2461DCFEF02@MA5P287MB6080.INDP287.PROD.OUTLOOK.COM> |
Thank you, Paul. Adding Chao from sophgo who may help checking this. Looping sophgo dev maillist, just FYI. Hi, Chao, Could you please have a look? Thanks, Chen On 7/8/2026 5:47 AM, Paul Sherman wrote: > Hi Chen, > > While working on PCIe bringup on my Milk-V Pioneer, I tracked down a > bug in zsbl where modify_bootargs() unconditionally appends > 'root=/dev/ram0' to the DTB chosen/bootargs node even when no ramfs is > configured. This silently overrides any root device in the DTB, in my > case the NVMe root, with no diagnostic output. > > The sg2260 platform already has the correct guard (cfg->ramfs.name == > NULL check). I've applied the same fix to sg2042/plat.c and opened a > PR against sophgo/zsbl: > > https://github.com/sophgo/zsbl/pull/135 > > Hardware-verified on the Pioneer (64-core, 128GB DDR4). Would > appreciate your review or a pointer to the right Sophgo maintainer if > that's not you. > > Best, > Paul