Re: [PATCH 2/2] riscv: dts: sophgo: cv180x: Fix internal ephy node name
Inochi Amaoto <[email protected]>
| Newsgroups | dev.linux.lists.sophgo,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 04, 2026 at 12:34:24AM +0800, Chen-Yu Yeh wrote:
> The internal EPHY node is named "phy@0" while its reg property is <1>.
> The unit-address should match the first entry of the reg property, but
> this is not checked by dtc for MDIO buses. The kernel confirms the PHY
> is indeed at address 1:
>
> eth0: PHY [mdio_mux-0.0:01] driver [Generic PHY]
>
> Rename the node to ethernet-phy@1, which also follows the common naming
> convention for ethernet PHY nodes.
>
> Fixes: ba1abacc57cb ("riscv: dts: sophgo: Add mdio multiplexer device for cv18xx")
>
> Signed-off-by: Chen-Yu Yeh <[email protected]>
> ---
> arch/riscv/boot/dts/sophgo/cv180x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv180x.dtsi b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> index ec3bf305274a..cf672cc6b935 100644
> --- a/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
> @@ -71,7 +71,7 @@ internal_mdio: mdio@0 {
> #size-cells = <0>;
> reg = <0>;
>
> - internal_ephy: phy@0 {
> + internal_ephy: phy@1 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <1>;
> };
> --
> 2.43.0
>
Please send this with the same thread of PATCH 1. Otherwise, LGTM
Reviewed-by: Inochi Amaoto <[email protected]>
Regards,
Inochi