[PATCH] thermal: spacemit: k1: disable hardware on driver remove
Pei Xiao <[email protected]> Mon, 13 Jul 2026 16:32:23 +0800
| Newsgroups | dev.linux.lists.spacemit,org.infradead.lists.linux-riscv,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <1db7d94eeaced9a92e3670d28e0c97c22f15f108.1783931396.git.xiaopei01@kylinos.cn> |
The driver uses devm_request_threaded_irq() but never disables the hardware interrupt enable, sensor enable, or sensor power bits when the driver is unbound. Add a devm action that clears K1_TSENSOR_INT_EN_REG, K1_TSENSOR_EN_ALL, and K1_TSENSOR_PCTRL_ENABLE on remove, mirroring what k1_tsensor_init() sets up. Signed-off-by: Pei Xiao <[email protected]> --- drivers/thermal/spacemit/k1_tsensor.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/thermal/spacemit/k1_tsensor.c b/drivers/thermal/spacemit/k1_tsensor.c index 79222d233129..cf79dc7d403f 100644 --- a/drivers/thermal/spacemit/k1_tsensor.c +++ b/drivers/thermal/spacemit/k1_tsensor.c @@ -199,6 +199,29 @@ static irqreturn_t k1_tsensor_irq_thread(int irq, void *data) return IRQ_HANDLED; } +static void k1_tsensor_shutdown(struct k1_tsensor *ts) +{ + u32 val; + + /* Disable all interrupts */ + writel(0xffffffff, ts->base + K1_TSENSOR_INT_EN_REG); + + /* Disable all sensor */ + val = readl(ts->base + K1_TSENSOR_EN_REG); + val &= ~K1_TSENSOR_EN_ALL; + writel(val, ts->base + K1_TSENSOR_EN_REG); + + /* Power down the sensor module */ + val = readl(ts->base + K1_TSENSOR_PCTRL_REG); + val &= ~K1_TSENSOR_PCTRL_ENABLE; + writel(val, ts->base + K1_TSENSOR_PCTRL_REG); +} + +static void devm_k1_tsensor_shutdown(void *data) +{ + k1_tsensor_shutdown(data); +} + static int k1_tsensor_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -229,6 +252,10 @@ static int k1_tsensor_probe(struct platform_device *pdev) k1_tsensor_init(ts); + ret = devm_add_action_or_reset(dev, devm_k1_tsensor_shutdown, ts); + if (ret) + return ret; + irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; -- 2.25.1