Re: [PATCH v2 1/2] PCI: Move Spacemit vendor and device IDs to linux/pci_ids.h

Bjorn Helgaas <[email protected]> Thu, 23 Jul 2026 17:01:40 -0500
Newsgroups dev.linux.lists.spacemit,org.infradead.lists.linux-riscv,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.linux-wireless
Message-ID <20260723220140.GA865834@bhelgaas>
On Thu, Jul 23, 2026 at 01:19:47AM +0000, Ping-Ke Shih wrote:
> Hi PCI maintainers,
> 
> Anirudh Srinivasan <[email protected]> wrote:
> > Move the vendor and device ID for the existing Spacemit K1 PCIe Root
> > Complex to include/linux/pci_ids.h. Also add K3's Root Complex device ID
> > to this header. This is done so that these values can be referenced in
> > the rtw89 driver to enable 36-bit DMA ability in it for WiFi to function
> > on the K3 Pico ITX board.
> > 
> > Acked-by: Bjorn Helgaas <[email protected]>
> > Signed-off-by: Anirudh Srinivasan <[email protected]>
> > ---
> >  drivers/pci/controller/dwc/pcie-spacemit-k1.c | 3 ---
> >  include/linux/pci_ids.h                       | 4 ++++
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> > b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> > index be20a520255b6..f89c6d46c7684 100644
> > --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> > +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> > @@ -21,9 +21,6 @@
> > 
> >  #include "pcie-designware.h"
> > 
> > -#define PCI_VENDOR_ID_SPACEMIT         0x201f
> > -#define PCI_DEVICE_ID_SPACEMIT_K1      0x0001
> > -
> >  /* Offsets and field definitions for link management registers */
> >  #define K1_PHY_AHB_IRQ_EN                      0x0000
> >  #define PCIE_INTERRUPT_EN              BIT(0)
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 1c9d40e09107d..d6f26cacc8e35 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2640,6 +2640,10 @@
> >  #define PCI_VENDOR_ID_SUNIX            0x1fd4
> >  #define PCI_DEVICE_ID_SUNIX_1999       0x1999
> > 
> > +#define PCI_VENDOR_ID_SPACEMIT         0x201f
> > +#define PCI_DEVICE_ID_SPACEMIT_K1      0x0001
> > +#define PCI_DEVICE_ID_SPACEMIT_K3      0x0002
> > +
> >  #define PCI_VENDOR_ID_HINT             0x3388
> >  #define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
> 
> As patch 2/2 obviously goes to wireless-next tree, can I take this 
> dependency patch to my tree? 

Yes, that's what my Acked-by at
https://lore.kernel.org/all/20260716164336.GA40813@bhelgaas means.