Re: [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu

Krzysztof Kozlowski <[email protected]> Wed, 29 Jul 2026 09:57:40 +0200
Newsgroups dev.linux.lists.spacemit,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On 29/07/2026 09:46, Baihui Liang wrote:
> On Tue, Jul 28, 2026, Krzysztof Kozlowski wrote:
> &gt; &gt; [...]
> &gt; &gt; spacemit,k3-gpu is added to the existing ti,am62-gpu/ti,am62p-gpu/
> &gt; &gt; ti,j721s2-gpu "if" block that restricts clocks to a single entry,
> &gt; &gt; since K3 has the same single-clock requirement. It does not match any
> &gt; &gt; "if" block that constrains power-domains, so that property falls back
> &gt;
> &gt; I don't get this explanation. Are you explaining what the patch is doing
> &gt; or explaining WHY you did this that way?
> 
> 
> That paragraph was describing schema mechanics, which does not belong in
> a commit message. v4 will drop it and state only the hardware facts: the
> K3 integration of the BXM-4-64 has a single "core" clock, and it has no
> software-controllable GPU power domain.
> 
> 
> &gt; &gt; to this schema's general constraints, where it is optional. This
> &gt; &gt; leaves room for a power-domains provider to be added later without a
> &gt; &gt; further binding change, should one ever be modelled in Linux for this
> &gt; &gt; SoC.
> &gt;
> &gt; No, you need to provide constraints now. Please read carefully
> &gt; writing-bindings.
> 
> 
> Understood. spacemit,k3-gpu currently matches no power-domains "if"
> block, so it falls back to the top-level 1-2 domains with
> power-domain-names "a"/"b". That would let a K3 DT with two power
> domains pass validation, which does not describe this hardware. v4 will
> add an explicit "if" block:
> 
> 
> &nbsp; &nbsp; - if:
> &nbsp; &nbsp; &nbsp; &nbsp; properties:
> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; compatible:
> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; contains:
> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; const: spacemit,k3-gpu
> &nbsp; &nbsp; &nbsp; then:
> &nbsp; &nbsp; &nbsp; &nbsp; properties:
> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; power-domains: false
> &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; power-domain-names: false

I understand only half of this. Please fix your email client.

And why this reply misses reply-to header which connects it to proper
thread? How am I supposed to find the thread now, among 200 I received
yesterday?

So your name is presented here as "Baihui Liang" then why do you use
some fake company name?



Best regards,
Krzysztof