Re: [PATCH 2/3] riscv: dts: spacemit: Add a common board dtsi for Milk-V Jupiter boards

On 2026-07-28 21:23, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The patch incorrectly removes the original authors' copyright headers from k1-milkv-jupiter.dts and replaces them with a single copyright claim by the patch author.
> --
> 
> --- Patch [2]: [PATCH 2/3] riscv: dts: spacemit: Add a common board dtsi for Milk-V Jupiter boards ---
> commit 97e4c73a96036da2bf4f3762abb7b076f18d6748
> Author: Aurelien Jarno <[email protected]>
> 
> riscv: dts: spacemit: Add a common board dtsi for Milk-V Jupiter boards
>     
> This commit adds a common board dtsi file for the Milk-V Jupiter board
> variants. It factors out common configurations into the new dtsi while
> excluding CPU operating points, which are left for the specific board files.
> 
> [ ... ]
> > diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> > index 3c16d0c20050e..9c4aa4f8a533c 100644
> > --- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
> > @@ -1,471 +1,11 @@
> >  // SPDX-License-Identifier: GPL-2.0 OR MIT
> >  /*
> > - * Copyright (C) 2024 Yangyu Chen <[email protected]>
> > - * Copyright (C) 2025 Javier Martinez Canillas <[email protected]>
> > + * Copyright (C) 2026 Aurelien Jarno <[email protected]>
> >   */
> 
> [Severity: Low]
> This isn't a bug, but should the original authors' copyright headers be
> retained here?
> 
> While the original copyright headers were correctly preserved in the newly
> created k1-milkv-jupiter-common.dtsi file where the bulk of the code was
> moved, standard practice is to retain the original attribution in the
> existing file as well, alongside any new copyright claims.

Thanks for the hint, I'll fix that in the next version.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
[email protected]                     http://aurel32.net