Re: [PATCH 1/2] ASoC: spacemit: Drop redundant error messages

--bf64bd363e0e8996a0a5ca0feb58c7dceb1ae0c90bcd07b3717d13d5a465
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Fri Jul 31, 2026 at 3:15 AM PDT, phucduc.bui wrote:
> From: bui duc phuc <[email protected]>
>
> The called functions already log failures where appropriate. Return the
> original error directly and avoid duplicate error messages.
>
> Signed-off-by: bui duc phuc <[email protected]>
> ---
>  sound/soc/spacemit/k1_i2s.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/spacemit/k1_i2s.c b/sound/soc/spacemit/k1_i2s.c
> index cd461f2aa756..64510c9a1a89 100644
> --- a/sound/soc/spacemit/k1_i2s.c
> +++ b/sound/soc/spacemit/k1_i2s.c
> @@ -478,7 +478,7 @@ static int spacemit_i2s_probe(struct platform_device =
*pdev)
> =20
>  	i2s->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(i2s->base))
> -		return dev_err_probe(i2s->dev, PTR_ERR(i2s->base), "failed to map regi=
sters\n");
> +		return PTR_ERR(i2s->base);
> =20
>  	i2s->reset =3D devm_reset_control_get_exclusive(&pdev->dev, NULL);
>  	if (IS_ERR(i2s->reset))
> @@ -495,7 +495,7 @@ static int spacemit_i2s_probe(struct platform_device =
*pdev)
>  					      &spacemit_i2s_component,
>  					      dai, 1);
>  	if (ret)
> -		return dev_err_probe(i2s->dev, ret, "failed to register component");
> +		return ret;
> =20
>  	return devm_snd_dmaengine_pcm_register(&pdev->dev, &spacemit_dmaengine_=
pcm_config, 0);
>  }
Reviewed-by: Troy Mitchell <[email protected]>


--=20
Troy Mitchell


--bf64bd363e0e8996a0a5ca0feb58c7dceb1ae0c90bcd07b3717d13d5a465
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIMEABYKACsWIQSL4Ay2cExaPXAQcU2YCe+A+TM0LwUCam/9MA0caUB0cm95LXku
b3JnAAoJEJgJ74D5MzQvAxQA/2DYCuc67ctUxgO1VADuU8NdphBXB5/3GDya8AM5
p+GmAQDtiqRFSDixu2qu42rj/vId1THpHiepPIVvYmqVFAwCCg==
=ZzYU
-----END PGP SIGNATURE-----

--bf64bd363e0e8996a0a5ca0feb58c7dceb1ae0c90bcd07b3717d13d5a465--