[SPDK] Expand your horizons with reviews!
Luse, Paul E <paul.e.luse at intel.com>
| Newsgroups | dev.linux.lists.spdk |
|---|---|
| Message-ID | <[email protected]> |
Hello Everyone, Wanted to take a minute to recognize those who spend so much time reviewing patches. Reviews are one of the most important things all of us can do to help build a vibrant community and continue to keep the quality level as high as it has been for years. It’s easy to fall into a “trap” though, where you tend to review only patches in areas of code that you know. We don’t want to discourage building expertise, of course, but it’s also critically important to review patches in areas of code that you don’t know. You’ll learn more about SPDK while at the same time providing potentially very valuable feedback. Don’t be shy about asking questions to learn, and let them know you are curious about the code; you’ll be amazed at how many times the author will rethink their implementation after someone with fresh eyes has taken a look. So remember, it’s the maintainers’ job review & approve, but it’s everyone’s job to review ☺ Thanks!! Paul