[SPDK] Reviews!

Luse, Paul E <paul.e.luse at intel.com> Fri, 21 May 2021 18:38:49 +0000
Newsgroups dev.linux.lists.spdk
Message-ID <BYAPR11MB3831B8863E20D6E3E9699924AD299@BYAPR11MB3831.namprd11.prod.outlook.com>
Hi Everyone,

Just a friendly reminder that we’re all responsible for maintaining SPDK’s strong reputation for high quality code.  There’s a bunch of ways to do that but I just want to call attention to one right now… REVIEWS!

Although the maintainers are responsible for the final votes on what goes in, they rely heavily on the opinions of everyone else; your review comments count.  And remember, when you review code you don’t need to be an expert in that area.  Sometimes a set of new eyes can really help the author see things that they might have missed being so close to the problem.  Additionally, spending time on reviews keeps you up to date on what’s happening in the always fast moving code base.

Reviewing is a learning experience, an exercise in collaboration and one of the many great ways community members can stay involved!

Thanks,
Paul