[SPDK] Re: SPDK_DEBUGLOG_FLAG_ENABLED behaviour

Hi Damien,

Good question.  I don’t have the history on this but would guess they were implemented at different times and one just didn’t follow suit wrt the use of a string or not. Is this causing a problem for you? (ie why not use a string in the SPDK_DEBUGLOG_FLAG_ENABLED and a flag for SPDK_DEBUGLOG as current SPDK modules do?)

Thx
Paul

From: Damien Thenot <damien.thenot(a)vates.fr>
Date: Thursday, January 13, 2022 at 10:04 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] SPDK_DEBUGLOG_FLAG_ENABLED behaviour
Hello,

I have been tinkering with SPDK code and was trying to use the macro
`SPDK_DEBUGLOG_FLAG_ENABLED` (defined in `include/spdk/log.h`).

This macro expects a string but other uses of the log interface, e.g.
`SPDK_DEBULOG`, expects a FLAG that will be turned in a string by the
macro directly.


For my usage, I modified the macro to stringify the FLAG. Is this
behaviour the expected one or is the current behaviour the correct one?

Best regards,

Damien Thenot


Damien Thenot | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com

_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org