[PATCH RFC] usb: gadget: midi2: Fix NULL pointer deref in f_midi2_free_ep_reqs()

When the gadget is unbound, f_midi2_unbind() unconditionally attempts to
free both endpoints (midi1_ep_in and midi1_ep_out). However, if an endpoint
was never initialized during f_midi2_bind() (e.g., because the direction
attribute of the first block was set to SNDRV_UMP_DIR_INPUT, skipping
midi1_ep_out initialization), its usb_ep->card pointer remains NULL.

When f_midi2_free_ep() calls f_midi2_free_ep_reqs(), it attempts to
dereference usb_ep->card to read the number of requests, leading to a
crash:

Oops: general protection fault, probably for non-canonical address
0xdffffc00000000ee: 0000 [#1] SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000770-0x0000000000000777]
RIP: 0010:f_midi2_free_ep_reqs drivers/usb/gadget/function/f_midi2.c:1166
[inline]
RIP: 0010:f_midi2_free_ep+0x52/0x2f0
drivers/usb/gadget/function/f_midi2.c:1208
Call Trace:
 f_midi2_unbind+0x9b/0x340 drivers/usb/gadget/function/f_midi2.c:2066
 purge_configs_funcs+0x248/0x3d0 drivers/usb/gadget/configfs.c:1600
 configfs_composite_unbind+0xa0/0x1b0 drivers/usb/gadget/configfs.c:1846
 gadget_unbind_driver+0x1cb/0x410 drivers/usb/gadget/udc/core.c:1724

To fix this, use usb_ep->num_reqs instead of usb_ep->card->info.num_reqs as
the loop boundary in f_midi2_free_ep_reqs() and f_midi2_alloc_ep_reqs().
For uninitialized endpoints, usb_ep->num_reqs is 0, which safely skips the
loop and avoids the crash. This also aligns with other cleanup functions
like f_midi2_drop_reqs() which already use usb_ep->num_reqs.

Fixes: 856fa444b098 ("usb: gadget: midi2: Dynamically create MIDI 1.0 altset descriptors")
Assisted-by: Gemini:gemini-3.5-flash Gemini:gemini-3.1-pro-preview syzbot
Reported-by: [email protected]
Closes: https://syzkaller.appspot.com/bug?extid=3451bfda4264c512ef27
Link: https://syzkaller.appspot.com/ai_job?id=87029043-73c1-4080-852b-012a419da14f
To: "Greg Kroah-Hartman" <[email protected]>
To: <[email protected]>
To: "Takashi Iwai" <[email protected]>
Cc: "Christophe JAILLET" <[email protected]>
Cc: "Kees Cook" <[email protected]>
Cc: <[email protected]>

---
diff --git a/drivers/usb/gadget/function/f_midi2.c b/drivers/usb/gadget/function/f_midi2.c
index 19fdac024..5e54cf994 100644
--- a/drivers/usb/gadget/function/f_midi2.c
+++ b/drivers/usb/gadget/function/f_midi2.c
@@ -1145,7 +1145,7 @@ static int f_midi2_alloc_ep_reqs(struct f_midi2_usb_ep *usb_ep)
 	if (!usb_ep->reqs)
 		return -EINVAL;
 
-	for (i = 0; i < midi2->info.num_reqs; i++) {
+	for (i = 0; i < usb_ep->num_reqs; i++) {
 		if (usb_ep->reqs[i].req)
 			continue;
 		usb_ep->reqs[i].req = alloc_ep_req(usb_ep->usb_ep,
@@ -1160,10 +1160,9 @@ static int f_midi2_alloc_ep_reqs(struct f_midi2_usb_ep *usb_ep)
 /* Free allocated requests */
 static void f_midi2_free_ep_reqs(struct f_midi2_usb_ep *usb_ep)
 {
-	struct f_midi2 *midi2 = usb_ep->card;
 	int i;
 
-	for (i = 0; i < midi2->info.num_reqs; i++) {
+	for (i = 0; i < usb_ep->num_reqs; i++) {
 		if (!usb_ep->reqs[i].req)
 			continue;
 		free_ep_req(usb_ep->usb_ep, usb_ep->reqs[i].req);


base-commit: f5098b6bae761e346ebcd9da7f95622c04733cff
-- 
This is an AI-generated patch subject to moderation.
Reply with '#syz upstream' to Sign-off the patch as a human author
and send it to the upstream kernel mailing lists.
Reply with '#syz reject' to reject it ('#syz unreject' to undo).

See https://goo.gle/syzbot-ai-patches for information about AI-generated patches.
You can comment on the patch as usual, syzbot will try to address
the comments and send a new version of the patch if necessary.
syzbot engineers can be reached at [email protected].