Re: [RFC PATCH 2/5] unwind: Export unwind_user symbol to GPL modules
Greg KH <[email protected]> Mon, 14 Jul 2025 15:26:47 +0200
| Newsgroups | dev.linux.lists.tech-board-discuss,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2025071419-negligent-balcony-84c5@gregkh> |
On Mon, Jul 14, 2025 at 08:20:33AM -0400, Steven Rostedt wrote: > On Mon, 14 Jul 2025 13:59:56 +0200 > Greg KH <[email protected]> wrote: > > > The maintainers of the subsystems in which the new code interacts with > > are the reviewers, as always. Again, nothing unusual here. > > What subsystems does it interact with? It is an observer, it doesn't affect > any subsystem. It's basically stand alone. It only needs to use the > tracepoint infrastructure (which BTW, Matiheu is the maintainer of). > > Just like perf and ftrace. They are stand alone subsystems where other > subsystems may interact with them, but they don't really interact with > anything else (besides the normal utilities like allocation of memory and > such). > > > > > > Have any suggestions for him, or do you just not care? But you are one of > > > the gate keepers of EXPORT_SYMBOL_GPL() which affects him. > > > > This is not the issue at all, sorry Just submit it like normal. > > So he could just send a thousand patch series that doesn't touch any other > subsystem? It would have a diffstat that touches nothing but kernel/lttng, > kernel/Makefile and kernel/Kconfig. Who's going to review it? Who's going > to accept it? Again, this is all things that we all know how to do and aren't new. Get someone in a subsystem relevant to it to review a patch series that adds the needed files to the kernel in a way that they can actually be reviewed. As it seems that we do have other tracing/perf developers already, start with them and go forward to see what they say. good luck! greg k-h