Re: [PATCH 04/21] gpiolib: provide gpio_device_get_desc()

Linus Walleij <[email protected]> Thu, 7 Sep 2023 09:07:53 +0200

Newsgroups	dev.linux.lists.timestamp,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-acpi,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-omap,org.kernel.vger.linux-tegra,org.kernel.vger.platform-driver-x86
Message-ID	<CACRpkdYCOVJZ6TUMQQHSaKZHMCx8tE8=3z=1BogYTkr52mFr8Q@mail.gmail.com>

On Tue, Sep 5, 2023 at 8:53 PM Bartosz Golaszewski <[email protected]> wrote:

> From: Bartosz Golaszewski <[email protected]>
>
> Getting the GPIO descriptor directly from the gpio_chip struct is
> dangerous as we don't take the reference to the underlying GPIO device.
> In order to start working towards removing gpiochip_get_desc(), let's
> provide a safer variant that works with an existing reference to struct
> gpio_device.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Andy had some good doc comments, with these addressed:
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij