[tpm2] CFLAGS and LIBS defines for tss versus other tpm2 projects
Roberts, William C <william.c.roberts at intel.com>
| Newsgroups | dev.linux.lists.tpm2 |
|---|---|
| Message-ID | <SN6PR11MB3437B20268B120BA4990AD5CB8D49@SN6PR11MB3437.namprd11.prod.outlook.com> |
So in all of the projects that need libcrypto, the configure.ac check using PKG_CHECK_MODULES uses "CRYPTO" except tss project which uses LIBCRYPT. This means that when exporting variables for building against a custom libcrypto, the variables will be LIBCRYPTO_CFLAGS and LIBCRYPTO_LIBS, where as all the other projects are just CRYPTO_CFLAGS and CRYPTO_LIBS. While it's not difficult to set both variables, I was wondering if we could unify this around CRYPTO (without the lib prefix) and if we consider configure.ac to be stable, ie if we made this change would we make someones life miserable? Thanks, Bill Configure.ac snippets below. tpm2-openssl/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 3.0.0], tpm2-pkcs11/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.1.0]) tpm2-tools/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.1.0]) tpm2-tss/configure.ac: PKG_CHECK_MODULES([LIBCRYPTO], tpm2-tss/configure.ac: [PKG_CHECK_MODULES([LIBCRYPTO],[libcrypto])]) tpm2-tss-engine/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.0.2g],
attachment.htm
(text/html, 3.4 KB)
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
So in all of the projects that need libcrypto, the configure.<span style="background-color:rgb(255,255,255); display:inline!important">ac check using PKG_CHECK_MODULES</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<span style="background-color:rgb(255,255,255); display:inline!important">uses "CRYPTO" except tss project which uses LIBCRYPT. This means that when exporting variables</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<span style="background-color:rgb(255,255,255); display:inline!important">for building against a custom libcrypto, the variables will be LIBCRYPTO_CFLAGS and LIBCRYPTO_LIBS,</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<span style="background-color:rgb(255,255,255); display:inline!important">where as all the other projects are just CRYPTO_CFLAGS and CRYPTO_LIBS. While it's not difficult to</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<span style="background-color:rgb(255,255,255); display:inline!important">set both variables, I was wondering if we could unify this around CRYPTO (without the lib prefix) and</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<span style="background-color:rgb(255,255,255); display:inline!important">if we consider configure.ac to be stable, ie if we made this change would we make someones life miserable?</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<span style="background-color:rgb(255,255,255); display:inline!important"><br>
</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<span style="background-color:rgb(255,255,255); display:inline!important">Thanks,</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<span style="background-color:rgb(255,255,255); display:inline!important">Bill</span></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Configure.ac snippets below.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
tpm2-openssl/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 3.0.0],
<div>tpm2-pkcs11/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.1.0])</div>
<div>tpm2-tools/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.1.0])</div>
<div>tpm2-tss/configure.ac: PKG_CHECK_MODULES([LIBCRYPTO],</div>
<div>tpm2-tss/configure.ac: [PKG_CHECK_MODULES([LIBCRYPTO],[libcrypto])])</div>
tpm2-tss-engine/configure.ac:PKG_CHECK_MODULES([CRYPTO], [libcrypto >= 1.0.2g],<br>
</div>
</body>
</html>