Re: [RFC PATCH 17/17] netfs: Combine prepare and issue ops and grab the buffers on request
David Howells <[email protected]>
| Newsgroups | dev.linux.lists.v9fs,dev.linux.lists.netfs,org.kernel.vger.ceph-devel,org.kernel.vger.linux-cifs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs |
|---|---|
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
| Message-ID | <[email protected]> |
ChenXiaoSong <[email protected]> wrote: > In netfs_writeback_single(), on the failure path, should we call > netfs_put_failed_request() instead of netfs_put_request()? It doesn't matter exactly, as the only difference really is whether it gets bumped over to a workqueue, but it's probably better to avoid that if we can. David