RE: [PATCH v5] virtio-net: Introduce a new field to indicate outer network header offset

Shiva Shankar Kommula <[email protected]>
Newsgroups dev.linux.lists.virtio-comment
Message-ID <DM4PR18MB4269F73B786E83EF68A70F37DFB82@DM4PR18MB4269.namprd18.prod.outlook.com>
> > -1215,6 +1241,11 @@ \subsubsection{Processing of Incoming
> > Packets}\label{sec:Device Types / Network  device MUST set the
> > VIRTIO_NET_HDR_GSO_ECN bit in  \field{gso_type}.
> >
> > +If VIRTIO_NET_F_OUT_NET_HEADER has been negotiated, the device MAY
> > set
> > +the \field{outer_nh_offset} to nonzero value to indicate outer
> > +network header offset, if packet contains a valid network header.
> > +Otherwise, the device MUST not use \field{outer_nh_offset}.
> > +
> >  If the VIRTIO_NET_F_GUEST_CSUM feature has been negotiated, the
> > device MAY set the VIRTIO_NET_HDR_F_NEEDS_CSUM bit in  \field{flags}, if
> so:
> > @@ -1302,6 +1333,10 @@ \subsubsection{Processing of Incoming
> > Packets}\label{sec:Device Types / Network
> >
> >  The driver MUST ignore \field{flag} bits that it does not recognize.
> >
> > +If VIRTIO_NET_F_OUT_NET_HEADER has been negotiated, and if
> > +\field{outer_nh_offset} is nonzero, the driver MAY use
> > +\field{outer_nh_offset} as outer network header offset. Otherwise,
> > +the
> > driver MUST not use the \field{outer_nh_offset}.
> > +
> >  If VIRTIO_NET_HDR_F_NEEDS_CSUM bit in \field{flags} is not set or  if
> > VIRTIO_NET_HDR_F_RSC_INFO bit \field{flags} is set, the  driver MUST
> > NOT use the \field{csum_start} and \field{csum_offset}.
> > --
> > 2.43.0
> 
> Reviewed-by: Parav Pandit <[email protected]>

Fixes:  https://github.com/oasis-tcs/virtio-spec/issues/222
Could you please open a voting ballot for these changes ?

Thanks 
Shiva
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.