Re: [PATCH v1] virtio-net: Fix to avoid using reserved feature bits

Paolo Abeni <[email protected]>
Newsgroups dev.linux.lists.virtio-comment
Message-ID <[email protected]>
Hi,

I'll try to consolidate here the current discussion.

My understanding is that the we are on same WRT that there is a problem
with the current spec.

On 4/28/25 11:13 AM, Michael S. Tsirkin wrote:
> Given features are negotiated first, we can just say the value
> can be 64 or 128 bits? In any case, I agree it's buggy as defined.

Do you mean that the 'offload' field should be 64 or 128 bits long
depending on the negotiated features?

Could that be problematic with VM migrations and/or backward
compatibility? I can't see a specific faulty scenario, but the 'implied'
field size sounds fragile to me.

/P
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.