Re: [PATCH v1] virtio: introduce SUSPEND and RESUME feature

On Thu, May 22, 2025 at 1:56 PM Qiang Zhang
<[email protected]> wrote:
>
> On Wed, May 21, 2025 at 06:20:49PM +0800, Zhu Lingshan wrote:
>
> Hi Lingshan,
>
> Thanks for your great work! I think we need more WRT suspend feature.
>
> Virtio device auto resume and guest wakeup features are not included
> in this patch. Since they are very related, can we add them this time?

Consider we've spent a huge effort to converge the design in
suspending. I'd like those to be added on top.


> For example, virtio input device may need to expose auto resume and
> guest wakeup capabilities present on USB mouse, keyboard etc.
>
>
> > This commit allows the driver to suspend the
> > device through a new device status bit SUSPEND
> > and resume the device running by re-setting
> > DRIVER_OK bit in device status.
> >
> > This commit re-orders the device status bits.
>
> A rough idea:
> A wakeup capability feature bit and a enable/disable control bit are
> required. If wakeup is supported and enabled, device can automatically
> wake up itself from suspended state to running state and raise a
> configuration change interrupt.
> Hypervisor can implement guest system wakeup basing on device's wakeup
> capability.

I'd expect this depends/requires transport support.

Thanks

>
> Thanks
> Qiang
>