RE: [PATCH v3 1/3] virtio: re-order device status bits
Parav Pandit <[email protected]>
| Newsgroups | dev.linux.lists.virtio-comment |
|---|---|
| Message-ID | <CY8PR12MB719556985E89D07B81EC5156DC7AA@CY8PR12MB7195.namprd12.prod.outlook.com> |
> From: Zhu Lingshan <[email protected]> > Sent: 23 June 2025 02:07 PM > > This commit re-orders the device status bits. A better message would be that defines their ordering, "Rearranged the bit definitions to list them in ascending order." > > Signed-off-by: Zhu Lingshan <[email protected]> > --- Anyways, Reviewed-by: Parav Pandit <[email protected]> > content.tex | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/content.tex b/content.tex > index d3fc6a4..1efc2a5 100644 > --- a/content.tex > +++ b/content.tex > @@ -36,19 +36,19 @@ \section{\field{Device Status} Field}\label{sec:Basic > Facilities of a Virtio Dev > this bit. For example, under Linux, drivers can be loadable modules. > \end{note} > > -\item[FAILED (128)] Indicates that something went wrong in the guest, > - and it has given up on the device. This could be an internal > - error, or the driver didn't like the device for some reason, or > - even a fatal error during device operation. > +\item[DRIVER_OK (4)] Indicates that the driver is set up and ready to > + drive the device. > > \item[FEATURES_OK (8)] Indicates that the driver has acknowledged all the > features it understands, and feature negotiation is complete. > > -\item[DRIVER_OK (4)] Indicates that the driver is set up and ready to > - drive the device. > - > \item[DEVICE_NEEDS_RESET (64)] Indicates that the device has experienced > an error from which it can't recover. > + > +\item[FAILED (128)] Indicates that something went wrong in the guest, > + and it has given up on the device. This could be an internal > + error, or the driver didn't like the device for some reason, or > + even a fatal error during device operation. > \end{description} > > The \field{device status} field starts out as 0, and is reinitialized to 0 by > -- > 2.49.0 >