Re: [PATCH v3 2/3] virtio: document feature bit 42
"Zhu, Lingshan" <[email protected]>
| Newsgroups | dev.linux.lists.virtio-comment |
|---|---|
| Message-ID | <[email protected]> |
On 6/26/2025 7:45 PM, Parav Pandit wrote: >> From: Zhu Lingshan <[email protected]> >> Sent: 23 June 2025 02:07 PM >> >> This commit documents feture bit 42 >> VIRTIO_NET_F_GUEST_RSC6 >> >> Fixes: 94384142 ("content: Declare virtio-net legacy feature bits 41-42") >> Signed-off-by: Zhu Lingshan <[email protected]> >> --- >> content.tex | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/content.tex b/content.tex >> index 1efc2a5..2e8da46 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a >> Virtio Device / Feature B \begin{description} >> \item[0 to 23, and 50 to 127] Feature bits for the specific device type >> >> -\item[24 to 41] Feature bits reserved for extensions to the queue and >> +\item[24 to 42] Feature bits reserved for extensions to the queue and >> feature negotiation mechanisms, see \ref{sec:Reserved Feature Bits} >> > This does not look accurate. > Bits 41 and 42 are used by the device specific type and not generic queue related mechanism. > In this case it is used by the net device. > > So right documentation should be, > > 0 to 23, 41, 42 and 50 to 127 Feature bits for the specific device type > > 24 to 40 Feature bits reserved for extensions to the queue and feature negotiation mechanisms > > 43 to 49, and 128 and above Feature bits reserved for future extensions. OK, this looks better > >> -\item[42 to 49, and 128 and above] Feature bits reserved for future >> extensions. >> +\item[43 to 49, and 128 and above] Feature bits reserved for future >> extensions. >> \end{description} >> >> \begin{note} >> -- >> 2.49.0 >>