Re: [PATCH v3 3/3] virtio: introduce SUSPEND and RESUME feature
"Zhu, Lingshan" <[email protected]>
| Newsgroups | dev.linux.lists.virtio-comment |
|---|---|
| Message-ID | <[email protected]> |
On 6/26/2025 9:40 PM, Parav Pandit wrote: >> From: Zhu, Lingshan<[email protected]> >> Sent: 26 June 2025 06:56 PM > [....] > > I wont be able to reply to this non text format inline. > So please find the reply here. > > I will not be able to take RFC 2119 keywords sprinkled in general description into the spec. > > Even worse, they are sprinkled non-consistently sometimes "SHOULD" and sometimes "should" in your patch. > > Virtio spec restricts usage of those keywords only in the requirements section. > Existing spec is an example of it in all the sections. do you find any sections documenting this restriction? If we want this rule, we should document it first in the spec. > > Please refer to the rest of the spec for such nomenclature. > The reasons are also explained in [1]. Please refer [1]. > > You didn't answer 'why is it so hard for your patch to follow the current spec nomenclature.' > i.e. to change 4 words... > If there is no reason, I do not want to debate on this anymore. > Both of us have more important things to do in virtio and otherwise. :) > > And I didn't ignore your comments, I replied with [2], which the last email in the thread. > > [1]https://lore.kernel.org/virtio-comment/CY8PR12MB71957FB8A0337FB62A1CDB41DC6AA@CY8PR12MB7195.namprd12.prod.outlook.com/T/#m3ea175d50e7ffc9816a322384e6766492215469f > [2]https://lore.kernel.org/virtio-comment/CY8PR12MB71957FB8A0337FB62A1CDB41DC6AA@CY8PR12MB7195.namprd12.prod.outlook.com/T/#m5d09faabdaf91a97b5844b040a19f5700c377870