Re: [PATCH v2 10/10] .github: add a runner to build the latest draft

Alex Bennée <[email protected]> Fri, 10 Oct 2025 14:58:53 +0100
Newsgroups dev.linux.lists.virtio-comment
Message-ID <[email protected]>
"Michael S. Tsirkin" <[email protected]> writes:

> On Fri, Oct 10, 2025 at 12:20:10PM +0100, Alex Bennée wrote:
>> This will run each time anything is pushed to the repository and store
>> the result in the release assets area of github. To see an example of
>> it in practice see the virtio-msg repo:
>> 
>>   https://github.com/Linaro/virtio-msg-spec/releases
>
> Is this the PDF?
>
> https://github.com/Linaro/virtio-msg-spec/releases/download/virtio-msg-rfc1-Linaro-draft-v14/virtio-msg-rfc1-Linaro-draft-v14.pdf
>
>
> Some comments:
> I suggest removing the version (e.g. replace with X.X)

Isn't the closest version still useful (to know its not based on a
really old version of the spec)?

> Replacing "Working Draft" with just "Draft"
> Maye stick the hash there too?

I've gone with:

  Unofficial Draft (@ git 8c7a1c3 with local changes)

to make it clear its outside of the normal OASIS stats.

> I also see front page corruption:
> driver listing overlaps with related work.

I think that predates my changes - I built from current HEAD and it has
the some overlap.

For the unofficial draft should we just elide the stage information
entirely as the links it generates don't point anywhere?

>
>
>
>
>
>
>> Signed-off-by: Alex Bennée <[email protected]>
>> Message-ID: <[email protected]>
>> ---
>>  .github/workflows/deploy.yaml | 37 +++++++++++++++++++++++++++++++++++
>>  .github/workflows/test.yml    | 15 ++++++++++++++
>>  2 files changed, 52 insertions(+)
>>  create mode 100644 .github/workflows/deploy.yaml
>>  create mode 100644 .github/workflows/test.yml
>> 
>> diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml
>> new file mode 100644
>> index 0000000..fec4910
>> --- /dev/null
>> +++ b/.github/workflows/deploy.yaml
>> @@ -0,0 +1,37 @@
>> +name: Deploy current state
>> +
>> +on: [push]
>> +
>> +jobs:
>> +  build:
>> +    runs-on: ubuntu-latest
>> +    steps:
>> +      - uses: actions/checkout@v4
>> +      - uses: xu-cheng/texlive-action@v2
>> +        with:
>> +          scheme: full
>> +          run: |
>> +            apk add file font-liberation make zip
>> +            make local-all
>> +            echo ${{ github.sha }} > Release.txt
>> +
>> +      - name: Create Draft Release
>> +        id: create_release
>> +        uses: actions/create-release@v1
>> +        env:
>> +          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
>> +        with:
>> +          tag_name: ${{github.ref_name}}-${{ github.repository_owner }}-draft-v${{ github.run_number }}
>> +          release_name: Draft ${{ github.run_number }}
>> +          draft: false
>> +          prerelease: false
>> +
>> +      - name: Upload Release Asset
>> +        uses: actions/upload-release-asset@v1
>> +        env:
>> +          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
>> +        with:
>> +          upload_url: ${{ steps.create_release.outputs.upload_url }}
>> +          asset_path: virtio-v1.4-wd01.pdf
>> +          asset_name: ${{github.ref_name}}-${{ github.repository_owner }}-draft-v${{ github.run_number }}.pdf
>> +          asset_content_type: application/pdf
>> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
>> new file mode 100644
>> index 0000000..34f4f44
>> --- /dev/null
>> +++ b/.github/workflows/test.yml
>> @@ -0,0 +1,15 @@
>> +name: CI
>> +
>> +on: [pull_request]
>> +
>> +jobs:
>> +  build:
>> +    runs-on: ubuntu-latest
>> +    steps:
>> +      - uses: actions/checkout@v4
>> +      - uses: xu-cheng/texlive-action@v2
>> +        with:
>> +          scheme: full
>> +          run: |
>> +            apk add file make zip
>> +            make local-html
>> -- 
>> 2.47.3
>> 

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro