Re: [PATCH v2] virtio-net: clarify guest offloads <> features mapping

Paolo Abeni <[email protected]> Mon, 9 Mar 2026 09:03:50 +0100
Newsgroups dev.linux.lists.virtio-comment
Message-ID <[email protected]>
Hi,

On 5/21/25 1:20 PM, Paolo Abeni wrote:
> The guest offloads, as specified by 'Setting Offloads State,' use a
> 64-bit wide space, while some of the corresponding virtio net features
> are in the upper 64 bits of a 128-bit wide space.
> 
> Clarify the relevant mapping as somewhat implied by the current text.
> Also rename the offload definitions to avoid referring to different
> numeric values with the same name in the features table and in the
> offload table.
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/225
> Signed-off-by: Paolo Abeni <[email protected]>
> ---
> v1 -> v2:
>   - restrict the mapped range to the guest offload (Parav)
>   v1: https://lore.kernel.org/virtio-comment/a30de484ff56065f56e37446e08dcdfa4850f101.1747649330.git.pabeni@redhat.com/

I'm sorry for the very long delay here. It was not clear to me I should
have explicitly asked a ballot on v2, too. Let me do that now:

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/225

I would like to ask a vote on this issues, thanks!

Paolo