[virtio-dev] Re: [virtio-comment] [PATCH] [PATCH v5] virtio-spi: add the device specification

On 11/30/2023 12:13 PM, Viresh Kumar wrote:
> On 29-11-23, 13:42, Cornelia Huck wrote:
>> On Wed, Nov 29 2023, Viresh Kumar <[email protected]> wrote:
>>
>>> On 29-11-23, 18:31, Haixu Cui wrote:
>>>> Hi Viresh,
>>>>
>>>>      Thank you for your helpful comments. In next patch, I will clearly point
>>>> this out:
>>>
>>> Great, finally we are on the same page. Thanks Haixu.
>>>
>>>>      "For full-duplex read and write transfer, both \field{tx_buf} and
>>>> \field{rx_buf} are used and the buffer size of \field{tx_buf} must be same
>>>> as \field{rx_buf}."
>>>
>>> Suggest rewriting as:
>>>
>>> In full-duplex transfer mode, both \field{tx_buf} and \field{rx_buf} are sent by
>>> the driver, \field{tx_buf} followed by \field{rx_buf}. The length of both the
>>> buffers MUST be same.
>>
>> Is that in a non-normative section? (Sorry, I've lost track here...)

Hi Viresh，
> 
> I think yes, though I am not sure where Haixu will put it eventually :)

I would like to put it in normative section, both for driver and device.

> 
>> If
>> so, I would say:
>>
>> "The length of both buffers has to be the same."
> 
> That's better. Thanks.
> 
>>> device MUST fail the transfer and notify the driver.
>>
>> "notify the driver" == "set an appropriate error value"?
>>
>> Can this be covered by one of the existing error values?
> 
> I think yes, this can be handled by the Param error.

Yes, this seems still in scope of parameter checking.

> 

Thanks & Best Regards

Haixu Cui

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]