Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification
Harald Mommer <[email protected]>
| Newsgroups | dev.linux.lists.virtio-dev,dev.linux.lists.virtio-comment |
|---|---|
| Message-ID | <[email protected]> |
Hello,
On 12.12.23 04:33, Haixu Cui wrote:
> +\field{bits_per_word_mask} is a mask indicating which values of bits_per_word are supported.
> +If bit n of \field{bits_per_word_mask} is set, the bits_per_word with value (n+1) is supported.
> +If all bits are not set, bits_per_word can be any value from 1 to 32.
"If all bits are not set" is not easy to understand as it means "if no
bit is set".
You can of course specify the value 0 this way to make code more
complicated.
To make code simple, 0 would be not given this special meaning. To allow
any value between 1 and 32 solely the value 0xFFFFFFFF would be allowed.
Which is already possible now without this additional sentence for 0.
Simply checking whether the respective bit is set in the mask and done
without having to add senseless additional code to handle the special
case that the mask is 0.
Giving 0 the same meaning as 0xFFFFFFFF brings nothing except confusion.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]