[virtio-dev] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing
Cornelia Huck <[email protected]> Mon, 29 Jan 2024 16:06:01 +0100
| Newsgroups | dev.linux.lists.virtio-dev,dev.linux.lists.virtio-comment |
|---|---|
| Organization | "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht München, HRB 153243, Geschäftsführer: Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" |
| Message-ID | <[email protected]> |
On Wed, Jan 24 2024, "Michael S. Tsirkin" <[email protected]> wrote: > This is not a huge deal since it's a SHOULD anyway, > so make the new requirement SHOULD too. > > Signed-off-by: Michael S. Tsirkin <[email protected]> > --- > device-types/net/description.tex | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/device-types/net/description.tex b/device-types/net/description.tex > index aff5e08..d1d25fe 100644 > --- a/device-types/net/description.tex > +++ b/device-types/net/description.tex > @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi > > The device MUST ignore \field{reserved}. > > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if > +it was not able to change coalescing parameters. In this case, Hm, if we explicitly specify "coalescing parameters" here, should we add it below as well? (We probably should keep the "the".) > +the parameters SHOULD remain unchanged, for all VQs. > + > > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]