Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

David Woodhouse <[email protected]> Mon, 01 Jul 2024 09:02:38 +0100
Newsgroups dev.linux.lists.virtio-dev,dev.linux.lists.virtualization,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-hardening,org.kernel.vger.linux-kernel,org.kernel.vger.linux-rtc,org.kernel.vger.netdev
Message-ID <[email protected]>
On Sun, 2024-06-30 at 14:28 +0100, Simon Horman wrote:
> 
> W=1 allmodconfig builds with gcc-13 flag the following.
> Reading the documentation of strncpy() in fortify-string.h,
> I wonder if strscpy() would be more appropriate in this case.

It's never going to matter in practice, as the buffer is 32 bytes, so
"vmclock%d" would never get to the end even if was a 64-bit integer.

But as a matter of hygiene and best practice, yes strscpy() would be
more appropriate. Fixed in git, thanks.
smime.p7s (application/pkcs7-signature, 5.8 KB) - not displayed