Re: [PATCH v4 2/3] virtio-spi: Add virtio-spi.h

On 8/20/2025 10:22 PM, Andy Shevchenko wrote:
> On Wed, Aug 20, 2025 at 04:49:43PM +0800, Haixu Cui wrote:
>> Add virtio-spi.h header for virtio SPI.
> 
> ...
> 
>> +/**
> 
> This is kernel-doc comment...
> 
>> + * struct virtio_spi_config - All config fields are read-only for the
>> + * Virtio SPI driver
> 
>> + */
> 
> ...
> 
>> +/*
>> + * @chip_select_id: chipselect index the SPI transfer used.
>> + *
> 
> But this one (besides having tons of unneeded blank lines) is not. Why is this
> inconsistency?
> 
>> + */
> 

Thank you for pointing out the inconsistency. I will update the comment 
to follow the kernel-doc format and remove the unnecessary blank lines.
This change will be reflected in the next patch version.

> ...
> 
>> +struct spi_transfer_result {
>> +#define VIRTIO_SPI_TRANS_OK	0
>> +#define VIRTIO_SPI_PARAM_ERR	1
>> +#define VIRTIO_SPI_TRANS_ERR	2
>> +	__u8 result;
>> +};
> 
> And this data type has no doc at all...
> 
Okay, will add definition for spi_tranafer_result.