Re: [PATCH v2 1/6] virtio: Add bool to VirtQueueElement

On 5/22/24 11:44 AM, Eugenio Perez Martin wrote:
> On Mon, May 20, 2024 at 3:01 PM Jonah Palmer <[email protected]> wrote:
>>
>> Add the boolean 'in_order_filled' member to the VirtQueueElement structure.
>> The use of this boolean will signify whether the element has been processed
>> and is ready to be flushed (so long as the element is in-order). This
>> boolean is used to support the VIRTIO_F_IN_ORDER feature.
>>
>> Tested-by: Lei Yang <[email protected]>
> 
> The code has changed from the version that Lei tested, so we should
> drop this tag until he re-test again.
> 
> Reviewed-by: Eugenio Pérez <[email protected]>
> 

My apologies. I wasn't sure if I should've removed the tag for all 
changes or just the significant changes.

>> Signed-off-by: Jonah Palmer <[email protected]>
>> ---
>>   include/hw/virtio/virtio.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
>> index 7d5ffdc145..88e70c1ae1 100644
>> --- a/include/hw/virtio/virtio.h
>> +++ b/include/hw/virtio/virtio.h
>> @@ -69,6 +69,8 @@ typedef struct VirtQueueElement
>>       unsigned int ndescs;
>>       unsigned int out_num;
>>       unsigned int in_num;
>> +    /* Element has been processed (VIRTIO_F_IN_ORDER) */
>> +    bool in_order_filled;
>>       hwaddr *in_addr;
>>       hwaddr *out_addr;
>>       struct iovec *in_sg;
>> --
>> 2.39.3
>>
>