Re: [PATCH RFC 02/15] vhost-user: Add memory-isolation qdev property to vhost-user devices

On Mon, Aug 3, 2026 at 5:21=E2=80=AFAM Hanna Czenczek <[email protected]> w=
rote:
>
> Should `vhost_user_vga_inst_initfn()` set up an alias for
> "memory-isolation", like it does for "chardev" now?
>

I am not 100% sure but I can test to see.  If an alias is needed, I suspect
that would also apply to vhost-user-gpu-pci, right?

>
> There are four lines in here that the checkpatch script notes to be over
> 80 characters in length, so they should be broken up.
>

Got it.  This will be fixed for the next rev.

> [...]
>
> > diff --git a/hw/virtio/vhost-user-base.c b/hw/virtio/vhost-user-base.c
> > index 90bd2903db..d2a74a2860 100644
> > --- a/hw/virtio/vhost-user-base.c
> > +++ b/hw/virtio/vhost-user-base.c
> > @@ -409,7 +409,8 @@ static void vub_device_unrealize(DeviceState *dev)
> >
> >   /*Define common qdev properties.  Inherited by all children*/
> >   static const Property vub_properties[] =3D {
> > -    DEFINE_PROP_CHR("chardev", VHostUserBase, chardev)
> > +    DEFINE_PROP_CHR("chardev", VHostUserBase, chardev),
> > +    DEFINE_PROP_BOOL("memory-isolation", VHostUserBase, memory_isolati=
on, false)
>
> Nitpick: I would add a comma here. (This hunk shows specifically why
> it=E2=80=99s a good idea: So that future additions don=E2=80=99t have to =
change the line
> to add the comma.)
>

Ah, I was wondering why I was seeing so many hanging commas .  That makes s=
ense.
I will add the comma in.