Re: [PATCH RFC 02/15] vhost-user: Add memory-isolation qdev property to vhost-user devices
Connor Kite <[email protected]>
| Newsgroups | dev.linux.lists.virtio-fs,org.nongnu.qemu-devel |
|---|---|
| Message-ID | <CA+spn3r=75BCypgw-D=MB7RA7EcET5QfvCtY10f+Azw+xMCUxQ@mail.gmail.com> |
On Tue, Aug 4, 2026 at 3:46 AM Hanna Czenczek <[email protected]> wrote: > > On 03.08.26 22:32, Connor Kite wrote: > > On Mon, Aug 3, 2026 at 5:21 AM Hanna Czenczek <[email protected]> wrote: > >> Should `vhost_user_vga_inst_initfn()` set up an alias for > >> "memory-isolation", like it does for "chardev" now? > >> > > I am not 100% sure but I can test to see. If an alias is needed, I suspect > > that would also apply to vhost-user-gpu-pci, right? > > Right, that makes sense. (If your testing confirms that it’s needed.) > > Hanna > Testing with both vhost-user-gpu-pcu and vhost-user-vga, the memory_isolation property is getting properly set in vhost_user without adding an alias. In both cases, dev->vdev refers to a VhostUserGpu, which has the memory_isolation qdev property set as in other vhost-user front-ends. Unlike most vhost-user front-ends, vhost-user-gpu does not define a "chardev" qdev property. Maybe that is why the "chardev" property needs to be aliased? However, I don't understand why "chardev" is not a qdev property as vhost-user-gpu already makes use of many of them. Best, Connor