Re: [PATCH RFC 09/15] hw/virtio/vhost-shadow-virtqueue: specified vring placement

On Fri, Jul 24, 2026 at 5:19 AM Akihiko Odaki
<[email protected]> wrote:
...
>
> Nit: please remove the whitespace between (void *) and svq->base_addr.
>

Removing the whitespace!

> > +        svq->vring.avail = (void *)((char *)svq->vring.desc + desc_size);
> > +        svq->vring.used = (void *)((char *)svq->base_addr +
> > +                          vhost_svq_driver_area_size(svq));
> > +    }
>
> Unmapping svq here can lead to use-after-unmapping because the ring is
> not stopped yet. do_vhost_dev_stop() calls do_vhost_virtqueue_stop()
> only after calling hdev->vhost_ops->vhost_dev_start(hdev, false).
>

I am afraid I don't quite understand, as this patch does not introduce
any unmapping.
Was this comment meant for a different patch?

...

> > +
> > +    /* Location assigned to vrings if not in default anon memory map*/
>
> Nit: here please add a whitespace before */
>

The whitespace is now added in.

Thanks!

Connor