Re: [PATCH RFC 09/15] hw/virtio/vhost-shadow-virtqueue: specified vring placement

Connor Kite <[email protected]> Fri, 7 Aug 2026 12:49:22 -0700

Newsgroups	dev.linux.lists.virtio-fs,org.nongnu.qemu-devel
Message-ID	<CA+spn3q=EZR1bx3tw-hnk=Hhqk1fNXmpqUoQwMv9km_hhcr3_Q@mail.gmail.com>

On Tue, Jul 28, 2026 at 8:23 AM Stefan Hajnoczi <[email protected]> wrote:
>
> Why is base_addr a hwaddr? This is QEMU memory, not guest RAM. I
> expected this to be void *.
>

It doesn't need to be hwaddr.  I will change it to void *

> A size needs to be at least documented here to reduce the chance of
> memory bugs. Even better would be an interface like
> vhost_svq_vring_total_size() so the caller can fetch the number of bytes
> before allocating the memory.

I haved added in a vhost_svq_vring_total_size function to address this now.

Best,
Connor