Re: [PATCH RFC v2 12/13] backends/cryptodev-vhost-user: add memory isolation bool

Connor Kite <[email protected]> writes:

> Add a memory_isolation property to CryptoDevBackendVhostUser and
> add add it as an optional member of CryptodevVhostUserProperties
> in qapi.
>
> This is needed to be able to specify memory isolation for
> cryptodev-vhost-user objects, and the bool will eventually be
> passed to vhost_user_init() in a future patch.
>
> Signed-off-by: Connor Kite <[email protected]>

[...]

> diff --git a/qapi/qom.json b/qapi/qom.json
> index c55776af7d..1024027195 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -350,11 +350,17 @@
>  # @chardev: the name of a Unix domain socket character device that
>  #     connects to the vhost-user server
>  #
> +# @memory-isolation: disable direct access from vhost-user back-end
> +#     to guest memory.  The back-end will instead access data via
> +#     bounce buffers residing in the QEMU virtual address space.
> +#     (default: false) (Since 11.2)

We spell it "backend" elsewhere in doc comments.

Any guidance on when to enable it?

> +#
>  # Since: 2.12
>  ##
>  { 'struct': 'CryptodevVhostUserProperties',
>    'base': 'CryptodevBackendProperties',
> -  'data': { 'chardev': 'str' },
> +  'data': { 'chardev': 'str',
> +            '*memory-isolation': 'bool' },
>    'if': 'CONFIG_VHOST_CRYPTO' }
>  
>  ##