Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout

Michal Luczaj <[email protected]> Thu, 23 Jul 2026 23:43:23 +0200
Newsgroups dev.linux.lists.virtualization,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>
On 7/23/26 12:26, Nguyen Dinh Phi [SG] wrote:
>>>>> ...
>>>>> Yeah, we need to handle that part better, I think it's a leftover when
>>>>> we generalized AF_VSOCK to support more transport than vmci.
>>>
>>> Speaking of leftovers, I have trouble understanding where does vsock set
>>> sk_err on listener sockets anyway. If it doesn't, why vsock_accept() 
>>> checks for it?
>>
>> I can't also see where it can be set TBH. Should we remove it ?
> 
> I couldn't find it for listener side too.

Removing sk_err handling from vsock_accept() solves the problem, right?

thanks,
Michal