Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout

On Fri, Jul 24, 2026 at 03:34:23PM +0800, Nguyen Dinh Phi [SG] wrote:
>On 24/7/26 05:43, Michal Luczaj wrote:
>>On 7/23/26 12:26, Nguyen Dinh Phi [SG] wrote:
>>>>>>>...
>>>>>>>Yeah, we need to handle that part better, I think it's a leftover when
>>>>>>>we generalized AF_VSOCK to support more transport than vmci.
>>>>>
>>>>>Speaking of leftovers, I have trouble understanding where does vsock set
>>>>>sk_err on listener sockets anyway. If it doesn't, why vsock_accept()
>>>>>checks for it?
>>>>
>>>>I can't also see where it can be set TBH. Should we remove it ?
>>>
>>>I couldn't find it for listener side too.
>>
>>Removing sk_err handling from vsock_accept() solves the problem, right?
>>
>>thanks,
>>Michal
>
>Yes, confirmed, removing sk_err checks from vsock_accept() does solve 
>the problem.

Okay, so maybe better on going on this direction. WDYT?

Stefano