Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout

Phi Nguyen <[email protected]> Thu, 30 Jul 2026 00:51:55 +0800
Newsgroups dev.linux.lists.virtualization,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>
On 7/29/2026 11:49 PM, Michal Luczaj wrote:
> On 7/29/26 15:29, Stefano Garzarella wrote:
>>
>> This is a good point!
>>
>> So we still need to remove `sk_err` check in vsock_accept(), or set
>> `sk->sk_err = 0` in vsock_listen() to have a complete fix, right?
> 
> Yup, that's my understanding as well.
> 
> That said, I'm not against flushing sk_err on a failed blocking connect()
> (this patch) as a follow up, if you guys agree that makes vsock behave like
> other socket families.

IMO, we should remove the sk_err check in vsock_accept() and invoke 
sock_error() in vsock_connnect()

Thanks,
Phi