Re: [PATCH] virtio_input: reset device if input_register_device() fails

Xiong Weimin <[email protected]> Wed, 05 Aug 2026 14:19:46 +0800
Newsgroups dev.linux.lists.virtualization,org.kernel.vger.linux-kernel,org.kernel.vger.stable
Message-ID <[email protected]>
On Wed, Aug 05, 2026 at 01:29:28AM -0400, Michael S. Tsirkin wrote:
> for each of these patches: is this a real or a theoretical issue?
> stable rules preclude the later kind.

For this virtio_input patch: theoretical for stable.

On the failing path, virtio_device_ready() has run, but
virtinput_fill_evt() has not, so the event queue still has no buffers.
I have no evidence of device DMA into torn-down queues here; the change
is lifecycle hygiene matching remove/freeze (clear DRIVER_OK before
del_vqs()).

I will drop Cc: stable on a v2 and keep the fix for mainline only.
I will answer the same question separately on the virtio_pci and
virtio_mmio threads.

Thanks,
Xiong