Re: [PATCH] vhost: clear vq->worker under vq->mutex when freeing workers

Sean Christopherson <[email protected]> Thu, 6 Aug 2026 06:53:12 -0700

Newsgroups	dev.linux.lists.virtualization,org.kernel.vger.kvm,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID	<[email protected]>

On Thu, Aug 06, 2026, Stefano Garzarella wrote:
> On Thu, Jul 23, 2026 at 06:33:10PM +0300, Andrey Drobyshev wrote:
> > The effect is harmless in practice, as this only happens while the
> > owning process (and thus the whole device) is dying, but the lockless
> > write is inconsistent with the rest of the code.  Clear vq->worker under
> > vq->mutex, like everyone else, so that all writers of vq->worker follow
> > the same locking rule.
> > 
> > This issue was found by Sashiko AI review.
> 
> Can you share a link to the review?
> 
> I don't know if it's common or not, but having the link in the commit or
> after --- will help the reviewers.

+1.  FWIW, I've been using and encouraging the "standard" Reported-by+Closes, e.g.

    Reported-by: Sashiko Bot <[email protected]>
    Closes: https://lore.kernel.org/all/[email protected]