Re: [PATCH] vdpa/pds: check virtqueue notify mapping

On 8/5/2026 5:58 PM, Xiong Weimin wrote:
> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Tue, Aug 04, 2026, Brett Creeley wrote:
>> Nit, but why dev_warn() instead of dev_err()? It looks like this was
>> copied, but I wonder if the other spot should be a dev_err() instead of
>> a dev_warn too?
>>
>> Other than that, LGTM.
>>
>> Reviewed-by: Brett Creeley <[email protected]>
> Thanks for the review. Agreed — this is a hard failure on the device
> add path, and the rest of pds_vdpa_dev_add() already uses dev_err().
> I'll send a standalone [PATCH v2] with that change and your
> Reviewed-by.
>
> The matching "Fail to map vq notify" in vp_vdpa.c is pre-existing; I
> can clean that up in a separate patch if you prefer.

You could try sending as a separate patch. I was just pointing out that, 
at least for pds_vdpa, this isn't a warning, but an error. I believe 
that's the case for vp_vdpa.c too.

Thanks,

Brett
>
> Thanks,
> Xiong