Re: [PATCH 3/3] hw/virtio: Add error handling for vhost_virtqueue_mask failure

Xiong Weimin <[email protected]> Fri, 7 Aug 2026 10:43:56 +0800
Newsgroups dev.linux.lists.virtualization,org.nongnu.qemu-devel
Message-ID <[email protected]>
On Fri, Jul 24, 2026 at 05:51:46AM -0400, Michael S. Tsirkin wrote:
> why is this part of this patchset?
>
> and then what happens?

It should not have been part of that series.  I am dropping the other
two patches and will resend this as a standalone change.

Also, the previous version was incomplete: vhost_virtqueue_mask() is
void today, so simply checking its return value was wrong.  The new
patch makes it return the errno from vhost_set_vring_call().  On
failure in vhost_virtqueue_start(), we jump to the existing fail path,
which unmaps the vring and returns the error so device start fails
instead of continuing with a half-configured queue.

Thanks,
Xiong Weimin