Re: [PATCH v6 2/3] vsock: remove the now-unused rejected flag
Stefano Garzarella <[email protected]>
| Newsgroups | dev.linux.lists.virtualization,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <an7aAsvcpoRd00ya@sgarzare-redhat> |
On Fri, Aug 14, 2026 at 01:30:19AM +0800, Nguyen Dinh Phi wrote:
>After previous patch, the branch marking a socket rejected in
>vsock_accept() is unreachable, and nothing ever sets vsk->rejected
>elsewhere.
>
>In fact, since commit d021c344051a ("VSOCK: Introduce VM Sockets"),
>where `rejected` was introduced, there has never been a path that sets
>sk_err on a listening socket, so that branch has been dead code since
>the beginning.
>
>Therefore, we can remove the `rejected` field from vsock_sock structure.
>
>Suggested-by: Stefano Garzarella <[email protected]>
>Signed-off-by: Nguyen Dinh Phi <[email protected]>
>---
> include/net/af_vsock.h | 5 +----
> net/vmw_vsock/af_vsock.c | 46 +++++++++++++---------------------------
> 2 files changed, 16 insertions(+), 35 deletions(-)
Thanks for improving the commit description!
Reviewed-by: Stefano Garzarella <[email protected]>