Re: [PATCH v7 111/120] x86/percpu: Add offset argument to x86_this_cpu_test_bit()

"Ahmed S. Darwish" <[email protected]> Fri, 12 Jun 2026 22:29:52 +0200
Newsgroups dev.linux.lists.x86-cpuid,org.kernel.vger.linux-kernel
Message-ID <aixsQMqwRJ925zBi@lx-t490>
On Mon, 01 Jun 2026, Maciej Wieczor-Retman wrote:
>
> On 2026-05-28 at 17:39:13 +0200, Ahmed S. Darwish wrote:
> >
> > diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
> > index 520949560138..b12bde4986b5 100644
> > --- a/arch/x86/include/asm/cpufeature.h
> > +++ b/arch/x86/include/asm/cpufeature.h
> > @@ -56,7 +56,7 @@ extern const char * const x86_bug_flags[NBUGINTS*32];
> >
> >  #define this_cpu_has(bit)						\
> >  	(__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 :	\
> > -	 x86_this_cpu_test_bit(bit, cpu_info.x86_capability))
> > +	 x86_this_cpu_test_bit(bit, cpu_info.x86_capability, 0))
>
> I think the same change needs to be applied in the same arch/um directory since
> it has a matching this_cpu_has() implementation and it uses x86's percpu.h.

arch/um/ has its own x86_capability[] implementation.

There are much higher priorities for this series than this.

Thanks!
Ahmed