Re: [tip: x86/urgent] x86/cpu: Add CPU model number for Bartlett Lake CPUs with Raptor Cove cores
Christian Ludloff <[email protected]>
| Newsgroups | dev.linux.lists.x86-cpuid,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAKSQd8Ug3Vk3A7eE6nB8UbhmOBBzVpfAqDYLf35Ym444MeQRdA@mail.gmail.com> |
> +#define INTEL_RAPTORCOVE IFM(6, 0xD7) /* Bartlett Lake */ Please fix this. It has the core and the product reversed. That is, it should be INTEL_BARTLETTLAKE and /* Raptor Cove */ to match the bulk of that file. And yes, you also want to fix this for INTEL_PANTHERCOVE_X and /* Diamond Rapids */ entry. The macros refer to products. The comments refer to cores. Consistency, please. Sanity, please. -- Christian