Re: [PATCH v1 07/26] x86/cpuid: Introduce debugfs 'x86/scanned_cpuid/[0-ncpus]'

Hi Sohil,

On Tue, 13 May 2025, Sohil Mehta wrote:
>
> I tried out the patches.
>

Thanks a lot for giving all of this a test run!

> The debugfs hierarchy mentioned here doesn't match the code.

Indeed.  I've added the extra level "cpus/" folder at a later phase and
forgot updating the changelog.

>
> The code actually builds:
>   x86/scanned_cpuid/cpus/[0-ncpus].
>
> Can we simplify it to below? The "scanned_" part seems unnecessary.
>   x86/cpuid/[0-ncpus]
>
> I would also suggest slight changes to the formatting to make it easier
> to read.
> 1) Indent for the printed register values.
> 2) Move the * to the front of the value to make it more prominent.
>

All the suggestions above are very sensible, so I'll do 'em in v2.

Thanks,
~ Ahmed